Fix Full DPS breakdown and gem dropdowns showing the wrong name for Companion / Spectre skills#2160
Merged
LocalIdentity merged 2 commits intoJun 13, 2026
Conversation
Companion and Spectre gems share a single granted effect ("Companion: {0}"
/ "Spectre: {0}") whose name is mutated globally for reservation display,
so every entry in the Full DPS breakdown showed the same minion name.
Derive each entry's name from the skill's own minion instead.
The dropdowns in the sidebar, calcs tab and compare tab also have an issue where they don't use the current minion name
LocalIdentity
changed the title
LocalIdentity
changed the title
LocalIdentity
approved these changes
Jun 13, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
I moved the function to calcs so that we can also use it to fix the same isssue with the wrong name being used for the Active Skill dropdown
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
…ompanion / Spectre skills (PathOfBuildingCommunity#2160) * Fix Full DPS breakdown showing the same name for all Companions Companion and Spectre gems share a single granted effect ("Companion: {0}" / "Spectre: {0}") whose name is mutated globally for reservation display, so every entry in the Full DPS breakdown showed the same minion name. Derive each entry's name from the skill's own minion instead. * Move function to cals + fix dropdowns The dropdowns in the sidebar, calcs tab and compare tab also have an issue where they don't use the current minion name --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion and Spectre gems share a single granted effect ("Companion: {0}" / "Spectre: {0}") whose name is mutated globally for reservation display, so every entry in the Full DPS breakdown showed the same minion name. Derive each entry's name from the skill's own minion instead.
Link to a build that showcases this PR:
https://pobb.in/-TeCx6SJiuWv
Before screenshot:
After screenshot: